Fix PointsDrawer hover/pin UX and PointsBreakdownTable accessibility#88
Merged
ashworks1706 merged 2 commits intocommit-that-shit-v3from Mar 7, 2026
Merged
Fix PointsDrawer hover/pin UX and PointsBreakdownTable accessibility#88ashworks1706 merged 2 commits intocommit-that-shit-v3from
ashworks1706 merged 2 commits intocommit-that-shit-v3from
Conversation
… UX, remove unused import Co-authored-by: ashworks1706 <85481905+ashworks1706@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update shop UI for better points breakdown accessibility
Fix PointsDrawer hover/pin UX and PointsBreakdownTable accessibility
Mar 7, 2026
ashworks1706
added a commit
that referenced
this pull request
Mar 7, 2026
* commit that shit * Update src/components/Shop/CategorySection.tsx Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Ben Juntilla <ben@benjuntilla.com> * Update CategorySection component * commit that shit * commit that shit * added mid loop stopping * edited animation issues * edited animation issues * Update src/components/Shop/PointsDrawer.tsx Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Ash Srivastava <85481905+ashworks1706@users.noreply.github.com> * Update src/pages/Shop/ShopIndex.tsx Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Ash Srivastava <85481905+ashworks1706@users.noreply.github.com> * Update src/components/Shop/ProductCarousel.tsx Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Ash Srivastava <85481905+ashworks1706@users.noreply.github.com> * Update src/components/Shop/PointsBreakdownTable.tsx Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Ash Srivastava <85481905+ashworks1706@users.noreply.github.com> * Fix PointsDrawer hover/pin UX and PointsBreakdownTable accessibility (#88) * Initial plan * fix: add scope=col to th headers, fix PointsDrawer pin/hover/keyboard UX, remove unused import Co-authored-by: ashworks1706 <85481905+ashworks1706@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: ashworks1706 <85481905+ashworks1706@users.noreply.github.com> --------- Signed-off-by: Ben Juntilla <ben@benjuntilla.com> Signed-off-by: Ash Srivastava <85481905+ashworks1706@users.noreply.github.com> Co-authored-by: Ben Juntilla <ben@benjuntilla.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
PointsDrawerwould close immediately onmouseLeaveregardless of click state, making "toggle open" non-functional. ThePointsBreakdownTablewas also missingscope="col"on header cells and had no keyboard dismissal path on the drawer.Changes
PointsDrawer.tsx: IntroduceisPinnedstate to separate hover-preview from click-to-pin:mouseLeaveonly closes if not pinnedisOpen)Escapekey closes and unpins viaonKeyDownon the outer containeronBlurcloses the drawer when focus leaves the container (unless pinned)PointsBreakdownTable.tsx: Addscope="col"to all<th>cells for proper AT table navigation alongside the existing row-spanned category cells.ShopIndex.tsx: Remove unusedPointsBreakdownTableimport (lint error).🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.